Skip to content

Log error when using platform flags with driver helm #2775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

johannesfrey
Copy link
Contributor

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves ENG-5648

Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster would silently ignore platform flags when using driver helm.

What else do we need to know?

neogopher
neogopher previously approved these changes May 13, 2025
Copy link
Contributor

@neogopher neogopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

FabianKramm
FabianKramm previously approved these changes May 23, 2025
@johannesfrey johannesfrey dismissed stale reviews from FabianKramm and neogopher via 8d800c8 May 23, 2025 07:21
@johannesfrey johannesfrey force-pushed the error-platform-flags-driver-helm branch from 0f8920d to 8d800c8 Compare May 23, 2025 07:21
@johannesfrey johannesfrey force-pushed the error-platform-flags-driver-helm branch from 8d800c8 to f024cd3 Compare May 23, 2025 07:31
@FabianKramm FabianKramm merged commit d407375 into loft-sh:main May 23, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants